Backend, Transport Module Refactor #413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PacketEvent to cut per-message allocations
…per-packet allocations
…use read locks for send paths
…ns, errors, TFTP, and TCP
…eplication and error sending
…se and remove SendFault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor transport to improve reliability, test coverage and performance by reducing per-packet allocations.
Implementation
bytes.Readerreuse to cut allocations.RWMutex; use read locks on send paths.errChansends to avoid nil error notifications.handleConversationandhandleSniffer; add unit coverage for packet handling, errors/notifications, TFTP read/write, and TCP/UDP server handlers; stabilize UDP tests by releasing pooled buffers and wiring encoder for packet id 100.